Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string formatting error when logging slow processing #156

Merged
merged 2 commits into from
May 28, 2021

Conversation

forsberg
Copy link
Contributor

Fixes crash in #153

Does not fix the suspected performance regression.

@forsberg forsberg force-pushed the 153-logging-error branch from 1b2ed70 to b6c253b Compare May 21, 2021 14:01
@forsberg forsberg force-pushed the 153-logging-error branch from b6c253b to ffa35fb Compare May 21, 2021 17:15
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #156 (ffa35fb) into master (bef8710) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   94.49%   94.53%   +0.03%     
==========================================
  Files         100      100              
  Lines       10627    10627              
  Branches     1201     1201              
==========================================
+ Hits        10042    10046       +4     
+ Misses        516      512       -4     
  Partials       69       69              
Impacted Files Coverage Δ
faust/transport/drivers/aiokafka.py 52.12% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef8710...ffa35fb. Read the comment docs.

@patkivikram patkivikram merged commit e71145c into faust-streaming:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants