Calling window close callback after popping the value from store #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current case, if a window is to be closed the start timestamp of the current window is checked against
last_closed_window
.Which means in this case if we are using
relative_to_field
for a Windowed Table and event comes with some old timestamp which is lesser thanlast_closed_window
, then thevalue
would already be popped but the on_window_close wouldn't be called.Ideally if window is closed we should be calling the on_window_close callback