Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix agents with multiple topics #116

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

stevanmilic
Copy link
Contributor

Description

A bug was introduced in fda7e52
where an asyncio task was using a topic name as its identifier. The
change isn't compatible with the Topic implementation where ValueError
is thrown for getting topic name when multiple names are set.

@codecov-io
Copy link

codecov-io commented Feb 27, 2021

Codecov Report

Merging #116 (4c3303e) into master (5b68580) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   93.75%   93.74%   -0.01%     
==========================================
  Files         100      100              
  Lines       10627    10619       -8     
  Branches     1196     1194       -2     
==========================================
- Hits         9963     9955       -8     
  Misses        611      611              
  Partials       53       53              
Impacted Files Coverage Δ
faust/agents/agent.py 98.06% <100.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b68580...4c3303e. Read the comment docs.

@patkivikram patkivikram merged commit 70e5516 into faust-streaming:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants