Skip to content

Commit

Permalink
allow only positive offsets to dictate recovery (#100)
Browse files Browse the repository at this point in the history
  • Loading branch information
patkivikram authored Feb 11, 2021
1 parent 9e1e8ac commit 466dbf2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion faust/tables/recovery.py
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ async def _maybe_signal_recovery_end(timeout=False, timeout_count=0) -> None:
# the aiokafka consumer position and draining of the queue
if timeout and self.app.in_transaction and timeout_count > 1:
await detect_aborted_tx()
if not self.active_remaining_total() and self.in_recovery:
if not self.need_recovery() and self.in_recovery:
# apply anything stuck in the buffers
self.flush_buffers()
self._set_recovery_ended()
Expand Down

0 comments on commit 466dbf2

Please sign in to comment.