Conversation
jrodewig
force-pushed
the
update-cli-v4
branch
from
cc5c954 to
8a3252d
Compare
jrodewig
force-pushed
the
update-cli-v4
branch
from
8a3252d to
3636365
Compare
findgriffin
left a comment
findgriffin
left a comment
There was a problem hiding this comment.
If you want, I can rejigger those test scripts, which are now referenced from .github/workflows and update this PR?
| fauna query --input seed/categories.fql --secret "$FAUNA_SECRET" | ||
| echo -e "\n\n" | ||
| fauna query --input seed/customers.fql --secret "$FAUNA_SECRET" | ||
| echo -e "\n\n" | ||
| fauna query --input seed/products.fql --secret "$FAUNA_SECRET" | ||
| echo -e "\n\n" | ||
| fauna query --input seed/orders.fql --secret "$FAUNA_SECRET" |
There was a problem hiding this comment.
You probably didn't see it, but I put a new file test/setup.sh that somewhat duplicates this file, I think we need to rename that file, or this file. Maybe we could rename this one seed.sh and put this script along with setup.sh and validate.sh in a directory called scripts?
There was a problem hiding this comment.
Thanks! I did the following:
- Renamed this file to
seed.shand placed it in/scripts. - Moved
/test/*files over to/scripts. - Updated references in
test.yml - Deleted some redundant data in
/seed/*.jsonfiles.
There's some additional work needed to update test.yml to the CLI v4 beta. Once that's done, we can just call seed.sh from setup.sh. However, that's a bit beyond the scope of this PR. I can tackle that in a separate PR if wanted.
Feel free to push changes to this PR/branch. Appreciate you taking a look!
2 participants
.seed.shfile so users can add test data.fqlfiles used for test data