Send Schema body as FormData; Format schema test file#349
Merged
Conversation
ecooper
approved these changes
Jul 24, 2024
ecooper
left a comment
ecooper
left a comment
There was a problem hiding this comment.
Am I crazy or is this like a 99% of this the first time these files have been linted/prettied?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s): FE-5644
Problem
Schema tests run in the pipeline (but not in CircleCI). They failed: https://concourse.faunadb.net/teams/devex/pipelines/fauna-shell-release/jobs/test/builds/22
Solution
Schema endpoint expects
Content-Type: multipart/form-data. We had that in place before, but swept through and updated allfetchcalls to use ReadableStream. Just needed to revert back to FormData for the Schema portion.Also applied some
prettierto the schema test fileResult