Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-6606: Introduce event cursor support #285

Merged
merged 1 commit into from
Aug 23, 2024
Merged

ENG-6606: Introduce event cursor support #285

merged 1 commit into from
Aug 23, 2024

Conversation

erickpintor
Copy link
Contributor

Description

Provide support for the new per-event stream cursor.

Motivation and context

There's an edge case where resuming a stream from a txn time with lots of documents written could result in event loss. This approach fixes that edge case.

How was the change tested?

Unit tests included.

Screenshots (if appropriate):

NA

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Narrow +1 on the README.

Copy link
Contributor

@ptpaterson ptpaterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is looking good! Just some thoughts on using the cursor.

src/client.ts Show resolved Hide resolved
@erickpintor erickpintor merged commit 75ee966 into main Aug 23, 2024
5 checks passed
@erickpintor erickpintor deleted the event-cursor branch August 23, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants