Skip to content

Comments

Make 802.1x test easier to use#940

Merged
noursaidi merged 4 commits intofaucetsdn:masterfrom
noursaidi:dot1xeasier
Dec 29, 2021
Merged

Make 802.1x test easier to use#940
noursaidi merged 4 commits intofaucetsdn:masterfrom
noursaidi:dot1xeasier

Conversation

@noursaidi
Copy link
Collaborator

  • Adds more meaningful messages and logging
  • Move certificates to a more user-friendly location

@noursaidi noursaidi requested review from anurag6 and pisuke December 19, 2021 14:23
@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #940 (cb589ca) into master (e9e851a) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head cb589ca differs from pull request most recent head 060b45a. Consider uploading reports for the commit 060b45a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
- Coverage   82.56%   82.50%   -0.07%     
==========================================
  Files          46       45       -1     
  Lines        5862     5693     -169     
==========================================
- Hits         4840     4697     -143     
+ Misses       1022      996      -26     
Flag Coverage Δ
ata 63.02% <ø> (+0.39%) ⬆️
aux 67.84% <ø> (-0.41%) ⬇️
base 65.97% <ø> (-0.55%) ⬇️
dhcp 67.12% <ø> (-0.38%) ⬇️
many 66.82% <ø> (-0.74%) ⬇️
mud 71.82% <ø> (-0.38%) ⬇️
switch 67.39% <ø> (-0.41%) ⬇️
topo 66.24% <ø> (-0.27%) ⬇️
unit 32.88% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/traffic_analyzer.py 86.50% <0.00%> (-3.18%) ⬇️
daq/topology.py 95.85% <0.00%> (-0.16%) ⬇️
daq/host.py 90.92% <0.00%> (-0.15%) ⬇️
daq/forchestrator.py 0.00% <0.00%> (ø)
daq/faucet_event_client.py
daq/runner.py 85.86% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e851a...060b45a. Read the comment docs.

result = 'failed'
test_result = "fail"
result_str += "Authentication for %s %s." % (src_mac, result)
additional = ' Incorrect credentials provided.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think incorrect credentials isn't the only reason for a test failure. Adding that as a reason for every failure might be misleading

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it so incorrect credentials only appears when incorrect credentials is the reason by checking if there is a RadiusAccessReject which suggests the EAP process was fine and the credentials were incorrect.

@noursaidi noursaidi merged commit 2aea73d into faucetsdn:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants