Make 802.1x test easier to use#940
Conversation
noursaidi
commented
Dec 19, 2021
- Adds more meaningful messages and logging
- Move certificates to a more user-friendly location
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
==========================================
- Coverage 82.56% 82.50% -0.07%
==========================================
Files 46 45 -1
Lines 5862 5693 -169
==========================================
- Hits 4840 4697 -143
+ Misses 1022 996 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| result = 'failed' | ||
| test_result = "fail" | ||
| result_str += "Authentication for %s %s." % (src_mac, result) | ||
| additional = ' Incorrect credentials provided.' |
There was a problem hiding this comment.
I think incorrect credentials isn't the only reason for a test failure. Adding that as a reason for every failure might be misleading
There was a problem hiding this comment.
I've changed it so incorrect credentials only appears when incorrect credentials is the reason by checking if there is a RadiusAccessReject which suggests the EAP process was fine and the credentials were incorrect.
cb589ca to
060b45a
Compare