Fix flaky aux ci test after enhanced nmap test#939
Merged
noursaidi merged 1 commit intofaucetsdn:masterfrom Jan 21, 2022
Merged
Fix flaky aux ci test after enhanced nmap test#939noursaidi merged 1 commit intofaucetsdn:masterfrom
noursaidi merged 1 commit intofaucetsdn:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #939 +/- ##
==========================================
+ Coverage 82.56% 82.63% +0.06%
==========================================
Files 46 46
Lines 5862 5862
==========================================
+ Hits 4840 4844 +4
+ Misses 1022 1018 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
grafnu
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky aux ci test after enhanced nmap test (PR #935 ) merged into master.
The enhanced nmap test results in slightly longer AUX test times. As the CI test duration is somewhat variable, on some runs the faux devices makes one additional DHCP request, resulting in a test fail.
This resolve that by upping the DHCP request threshold from 5 to 6
Example successful CI: https://github.com/faucetsdn/daq/runs/4537256530?check_suite_focus=true
Example failure CI: https://github.com/faucetsdn/daq/runs/4559129359?check_suite_focus=true