Skip to content

Comments

Fix flaky aux ci test after enhanced nmap test#939

Merged
noursaidi merged 1 commit intofaucetsdn:masterfrom
noursaidi:flaky-aux
Jan 21, 2022
Merged

Fix flaky aux ci test after enhanced nmap test#939
noursaidi merged 1 commit intofaucetsdn:masterfrom
noursaidi:flaky-aux

Conversation

@noursaidi
Copy link
Collaborator

@noursaidi noursaidi commented Dec 17, 2021

Fix flaky aux ci test after enhanced nmap test (PR #935 ) merged into master.

The enhanced nmap test results in slightly longer AUX test times. As the CI test duration is somewhat variable, on some runs the faux devices makes one additional DHCP request, resulting in a test fail.

This resolve that by upping the DHCP request threshold from 5 to 6

Example successful CI: https://github.com/faucetsdn/daq/runs/4537256530?check_suite_focus=true
Example failure CI: https://github.com/faucetsdn/daq/runs/4559129359?check_suite_focus=true

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #939 (59eba79) into master (e9e851a) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   82.56%   82.63%   +0.06%     
==========================================
  Files          46       46              
  Lines        5862     5862              
==========================================
+ Hits         4840     4844       +4     
+ Misses       1022     1018       -4     
Flag Coverage Δ
ata 63.86% <ø> (+1.23%) ⬆️
aux 68.21% <ø> (-0.04%) ⬇️
base 66.30% <ø> (-0.23%) ⬇️
dhcp 67.50% <ø> (ø)
many 67.20% <ø> (-0.35%) ⬇️
mud 72.03% <ø> (-0.16%) ⬇️
switch 67.77% <ø> (-0.02%) ⬇️
topo 66.44% <ø> (-0.07%) ⬇️
unit 32.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/traffic_analyzer.py 86.50% <0.00%> (-3.18%) ⬇️
daq/acl_state_collector.py 80.82% <0.00%> (-2.74%) ⬇️
daq/runner.py 85.75% <0.00%> (+0.20%) ⬆️
daq/host.py 91.35% <0.00%> (+0.28%) ⬆️
daq/tcpdump_helper.py 80.95% <0.00%> (+2.38%) ⬆️
daq/stream_monitor.py 90.08% <0.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e851a...59eba79. Read the comment docs.

@noursaidi noursaidi requested a review from grafnu January 5, 2022 20:58
@noursaidi noursaidi merged commit 987f8a0 into faucetsdn:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants