-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporting color.SetWriter / UnsetWriter #124
Comments
Hi @itchyny this looks like something we can do. Let me think about this a little bit. Thank you for your feedback. |
I would be happy to implement this. What do you think about implementing |
I'm ok with only exporting the two functions. Currently I use |
I'm in same boat as @itchyny. |
For some users performance is very important and hence having access to the underlying writer functions allow them to use bytes buffer and avoid string allocations. closes #124
This is fixed now, I'm going to release a new version soon with the fields being exported. Sorry for the late changes on this, 2021 was when I moved back from the US to Turkey, and I'm slowly going over my some of my OSS work. |
Now
color.Set
andcolor.Unset
are exported so that we can color output to the standard output. Can you exportcolor.SetWriter
andcolor.UnsetWriter
? This is pretty useful when we cannot change the code to Fprint style. Also usingw.Write
beats Fprint* functions in performance because it does not scan for formatting.The text was updated successfully, but these errors were encountered: