Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add trailing slash to base_url on pooch.create #344

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

gabrielfu
Copy link
Contributor

@gabrielfu gabrielfu commented Feb 20, 2023

Automatically add a trailing "/" to base_url in pooch.create() if missing. Update docstring and add test function that checks if the trailing slash gets added.

Relevant issues/PRs:

Fixes #324

@welcome
Copy link

welcome bot commented Feb 20, 2023

💖 Thank you for opening your first pull request in this repository! 💖

A few things to keep in mind:

No matter what, we are really grateful that you put in the effort to do this!

@santisoler santisoler changed the title feat: add trailing "/" to base_url Automatically add trailing slash to base_url on pooch.create Feb 21, 2023
@santisoler santisoler changed the title Automatically add trailing slash to base_url on pooch.create Automatically add trailing slash to base_url on pooch.create Feb 21, 2023
@santisoler
Copy link
Member

Thanks for the contribution @gabrielfu! I think this is ready to be merged! I just added a small test function to prevent us breaking this feature in the future.

I'm merging it as soon as the Actions pass. 🚀

@santisoler santisoler merged commit cd62dd3 into fatiando:main Feb 21, 2023
@welcome
Copy link

welcome bot commented Feb 21, 2023

🎉 Congrats on merging your first pull request and welcome to the team! 🎉

If you would like to be added as a author on the Zenodo archive of the next release, add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file of this repository. Feel free to do this in a new pull request if needed.

We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically add a trailing "/" to base_url in pooch.create
2 participants