Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dependente to capture dependencies on CI #289

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Use Dependente to capture dependencies on CI #289

merged 3 commits into from
Jan 10, 2022

Conversation

leouieda
Copy link
Member

Dependente (https://github.com/fatiando/dependente) does what the code
in our tools folder did. Use it instead. Add the extra dependencies to
setup.cfg as install targets for pip so that they can be extracted by
dependente.

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

Dependente (https://github.com/fatiando/dependente) does what the code
in our `tools` folder did. Use it instead. Add the extra dependencies to
setup.cfg as install targets for pip so that they can be extracted by
dependente.
@leouieda leouieda marked this pull request as draft January 10, 2022 13:55
@leouieda leouieda marked this pull request as ready for review January 10, 2022 14:01
@leouieda
Copy link
Member Author

Workflows are failing kind of randomly. Rerun again in a little while.

@leouieda leouieda merged commit 52240b9 into main Jan 10, 2022
@leouieda leouieda deleted the dependente branch January 10, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant