Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file_hash back to pooch.utils with a warning #257

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Conversation

leouieda
Copy link
Member

Moving this function to pooch.hashes caused crashes downstream. To prevent these crashes, add a wrapper back to utils that issues a warning to import from the top-level namespace instead.

Fixes #252

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

Moving this function to pooch.hashes caused crashes downstream. To
prevent these crashes, add a wrapper back to utils that issues a warning
to import from the top-level namespace instead.
@leouieda leouieda requested a review from hmaarrfk August 24, 2021 08:10
We don't want all users seeing this, just developers
@leouieda leouieda merged commit be3f32d into master Aug 24, 2021
@leouieda leouieda deleted the file-hash-fix branch August 24, 2021 11:46
@hmaarrfk
Copy link
Contributor

Sorry for the trouble @leouieda !

@leouieda
Copy link
Member Author

Not at all. Just glad we caught this quickly and the fix was relatively easy 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: cannot import name 'file_hash' from 'pooch.utils'
2 participants