-
-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/entry validation alerts #101
Conversation
…rs through Slack of invalid entries
|
The cron job seems to be working but it's the part I'm least confident in... so if someone with more experience in Docker could pay extra attention to my changes there could have a look I'd appreciate it. |
|
hey @bronzdoc, your DevOps wisdom is needed! could you review this when you have the time? thanks! |
bronzdoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcelaney I left some comments regarding style, mocking, and a suggestion for the docker problem. Let me know what you think, thanks!
|
@bronzdoc Makes sense to me. I'll pull the cron stuff back out. |
We'll expect these to be set up as workers in Heroku
|
@bronzdoc hey, looks like this is ready for re-review |
|
This PR is blocked by #100 |
|
@arielj hey, do you think you can help review this PR? If you don't have time I can try to find someone else. Thank you! |
bronzdoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, still needs a rebase tho
| end | ||
| end | ||
|
|
||
| # let(:user) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this commented code?
etagwerker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this locally and it seems to behave as expected. I had to tweak something in the spec so that it passes (both locally and in CI)
Closes #98
Description:
Once a day, we should have a scheduled job that reviews all the entries submitted by the team during that day. The task should probably run every weekday at 8pm in the user's local time zone as defined by Slack.
Initially only internal employees would receive these messages. We determine which users to include by inspecting the
@ombuteamon Slack.The job would check that the entries are well formed. They should meet this criteria:
The notification should include a list of entries that look suspicious. Here is a template:
To Do
QA
I will abide by the code of conduct.