-
Notifications
You must be signed in to change notification settings - Fork 4
Add section in README describing workaround when using dotenv_validator
with Docker
#51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, I added a new idea to try as a workaround, if using a different file name instead of .env
works we can suggest that in the README instead, since docker-compose looks for a .env file and is not as flexible as Dotenv we can use that feature of Dotenv
Looks good to me, but I wonder if we should test Ariel's idea about changing the name of the file to |
d46e17e
to
9a64eba
Compare
@kindoflew Already did and it worked. Added the instruction in the README |
then looks good to me! |
So, I'm new to Github actions, what exactly is happening on that task that keeps failing. I went to the description but it only said it was cancelled and not much in the way of what went wrong... |
@mateusdeap That was recently fixed in #53 |
9a64eba
to
673d22b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one small comment, but otherwise this looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mateusdeap Looks good, thanks!
Description:
Kind of fixes #46. The reason we get this bug is actually only when using docker and the reason is that Docker will parse any
.env
files present in the project. They do have an option for us to set a custom .env file, and we tried setting it to an empty file, but it would still parse.env
and assign values toENV
that included the white space and comments.We decided to simply update the README to warn users of this issue and that, currently, the only workaround is to remove any comments from the
.env
file.I will abide by the code of conduct.