Skip to content

Add section in README describing workaround when using dotenv_validator with Docker #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

mateusdeap
Copy link
Member

Description:
Kind of fixes #46. The reason we get this bug is actually only when using docker and the reason is that Docker will parse any .env files present in the project. They do have an option for us to set a custom .env file, and we tried setting it to an empty file, but it would still parse .env and assign values to ENV that included the white space and comments.

We decided to simply update the README to warn users of this issue and that, currently, the only workaround is to remove any comments from the .env file.

I will abide by the code of conduct.

Copy link
Contributor

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, I added a new idea to try as a workaround, if using a different file name instead of .env works we can suggest that in the README instead, since docker-compose looks for a .env file and is not as flexible as Dotenv we can use that feature of Dotenv

@kindoflew
Copy link
Contributor

kindoflew commented Nov 24, 2021

Looks good to me, but I wonder if we should test Ariel's idea about changing the name of the file to .env.local as that is an already established naming convention?

@mateusdeap mateusdeap force-pushed the feature/describe-workaround-for-docker branch from d46e17e to 9a64eba Compare November 24, 2021 19:40
@mateusdeap
Copy link
Member Author

@kindoflew Already did and it worked. Added the instruction in the README

@mateusdeap mateusdeap requested a review from arielj November 24, 2021 19:41
@kindoflew
Copy link
Contributor

kindoflew commented Nov 24, 2021

then looks good to me!

@mateusdeap
Copy link
Member Author

So, I'm new to Github actions, what exactly is happening on that task that keeps failing. I went to the description but it only said it was cancelled and not much in the way of what went wrong...

@lubc
Copy link
Contributor

lubc commented Nov 25, 2021

So, I'm new to Github actions, what exactly is happening on that task that keeps failing. I went to the description but it only said it was cancelled and not much in the way of what went wrong...

@mateusdeap That was recently fixed in #53
You can pull from main so it works on this PR too

@mateusdeap mateusdeap force-pushed the feature/describe-workaround-for-docker branch from 9a64eba to 673d22b Compare November 25, 2021 18:05
@mateusdeap mateusdeap requested a review from arielj November 25, 2021 18:05
Copy link
Contributor

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one small comment, but otherwise this looks good to me

@mateusdeap mateusdeap requested a review from arielj December 1, 2021 13:13
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateusdeap Looks good, thanks!

@etagwerker etagwerker merged commit d1fec86 into main Dec 1, 2021
@etagwerker etagwerker deleted the feature/describe-workaround-for-docker branch December 1, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Int format is not valid if .env file includes white spaces
5 participants