Fix transcript performance issues #1643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR restructures the desktop application's transcript rendering pipeline with virtualized scrolling, refactors editor state management to use store-based initialization, simplifies the streaming status component, adds debug seed data generation, and applies consistent patterns for debounced editor updates across TipTap and note editors. Changes
Sequence Diagram(s)sequenceDiagram
participant Store
participant Component as Enhanced/Raw Editor
participant NoteEditor
participant User
rect rgb(240, 248, 255)
Note over Store,User: Store-based Initialization Pattern
Component->>Store: useStore() on mount
Store-->>Component: Store instance
Component->>Component: useEffect trigger
Component->>Store: getCell("sessions", sessionId, "content_field")
Store-->>Component: Initial content value
Component->>Component: setInitialContent(value)
end
rect rgb(245, 245, 220)
Note over Component,NoteEditor: Render & Sync
Component->>NoteEditor: Pass initialContent + handleChange
NoteEditor->>User: Display editor
User->>NoteEditor: Edit content
NoteEditor->>Component: onUpdate → handleChange(markdown)
Component->>Store: setPartialRow() [via callback]
Store-->>Component: Store updated
end
sequenceDiagram
participant RenderTranscript
participant VirtualizedSegments as Virtualizer
participant SegmentRenderer
participant WordSpan
participant AudioContext as useAudioPlayer
rect rgb(240, 248, 255)
Note over RenderTranscript,AudioContext: Transcript Rendering with Virtualization
RenderTranscript->>RenderTranscript: useFinalWords()
RenderTranscript->>RenderTranscript: useFinalSpeakerHints()
RenderTranscript->>RenderTranscript: buildSegments()
RenderTranscript->>VirtualizedSegments: Pass segments + metadata
end
rect rgb(255, 250, 205)
Note over VirtualizedSegments,WordSpan: Dynamic Rendering
VirtualizedSegments->>VirtualizedSegments: Compute visible items
loop For each visible segment
VirtualizedSegments->>SegmentRenderer: Render segment
SegmentRenderer->>AudioContext: Query currentMs, seek
loop For each word in segment
SegmentRenderer->>WordSpan: Pass word + highlight state
WordSpan->>WordSpan: getWordHighlightState(editable, audioExists, currentMs, timing)
WordSpan-->>SegmentRenderer: Render with highlight/operations
end
end
end
rect rgb(220, 240, 220)
Note over WordSpan,AudioContext: User Interaction
WordSpan->>WordSpan: User clicks word
WordSpan->>AudioContext: seekAndPlay(wordStartMs)
AudioContext-->>WordSpan: Audio seeks & plays
end
sequenceDiagram
participant StreamingView
participant Status
participant useAITaskTask as Hook
participant Task
rect rgb(255, 245, 240)
Note over StreamingView,Status: Before: Prop-driven Status
StreamingView->>Hook: useAITaskTask(taskId)
Hook-->>StreamingView: {cancel, isGenerating, ...}
StreamingView->>Status: Pass taskId, cancel, isGenerating
end
rect rgb(240, 255, 240)
Note over StreamingView,Status: After: Self-contained Status
StreamingView->>Status: Pass taskId only
Status->>Hook: useAITaskTask(taskId)
Hook-->>Status: {cancel, isGenerating, currentStep, ...}
Status->>Status: Render button if isGenerating
Status->>Task: onClick → cancel()
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~40 minutes Areas requiring extra attention:
Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (23)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Nov 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.