Skip to content

fix: apply cargo clippy fixes across workspace#4464

Open
devin-ai-integration[bot] wants to merge 4 commits intomainfrom
devin/1773014536-clippy-fixes
Open

fix: apply cargo clippy fixes across workspace#4464
devin-ai-integration[bot] wants to merge 4 commits intomainfrom
devin/1773014536-clippy-fixes

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Mar 9, 2026

Summary

Ran cargo clippy --fix and manually applied remaining suggestions to clean up clippy warnings across the workspace.

Changes in this PR:

  • Removed unnecessary .to_string() on a &str in crates/analytics/src/posthog.rs
  • Collapsed nested if/if let into let-chains in:
    • crates/tiptap/src/from_ast.rs
    • plugins/fs-db/src/version/macro.rs
    • plugins/fs-db/src/migrations/v1_0_2_nightly_14_extract_from_sqlite.rs
    • plugins/fs-db/src/migrations/v1_0_2_nightly_1_from_v0.rs
    • plugins/listener/src/actors/recorder.rs
  • Removed unnecessary explicit lifetime annotations in group_by_session_id in two migration files (lifetime elision suffices)
  • Removed unused use tauri::Manager import in apps/desktop/src-tauri/src/lib.rs
  • Added plugins/cli2 to workspace exclude list in Cargo.toml (directory lacks Cargo.toml, was causing workspace resolution failures)

All changes are linting/style fixes with no intentional functional changes to logic. All meaningful CI checks pass (macOS, Linux x86_64, Linux aarch64, fmt).

Note: The batch CI check fails due to a pre-existing cactus-sys ARM build issue on x86 runners, unrelated to these changes.

Review & Testing Checklist for Human

Risk level: Green (mechanical clippy fixes, all CI checks pass)

  • Spot-check let-chain formatting — some files have extra indentation in the body (e.g., from_ast.rs, macro.rs) while recorder.rs uses standard formatting. dprint passed, but verify this variation is intentional.
  • Confirm use tauri::Manager removal doesn't affect macOS runtime behavior (CI tests passed, but runtime usage may differ from test coverage)

Test plan

CI passing on all platforms (macOS, Linux x86_64, Linux aarch64) provides good coverage for these mechanical fixes. Consider spot-testing macOS desktop app startup to confirm Manager removal is safe.

Notes

Co-Authored-By: bot_apk <apk@cognition.ai>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@netlify
Copy link

netlify bot commented Mar 9, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 8b396a7
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69ae14af1c4f7800086d41b8

@netlify
Copy link

netlify bot commented Mar 9, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 8b396a7
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/69ae14aff34f320008cdea00

devin-ai-integration bot and others added 3 commits March 9, 2026 00:16
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants