fix: apply cargo clippy fixes across workspace#4464
Open
devin-ai-integration[bot] wants to merge 4 commits intomainfrom
Open
fix: apply cargo clippy fixes across workspace#4464devin-ai-integration[bot] wants to merge 4 commits intomainfrom
devin-ai-integration[bot] wants to merge 4 commits intomainfrom
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
Co-Authored-By: bot_apk <apk@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ran
cargo clippy --fixand manually applied remaining suggestions to clean up clippy warnings across the workspace.Changes in this PR:
.to_string()on a&strincrates/analytics/src/posthog.rsif/if letinto let-chains in:crates/tiptap/src/from_ast.rsplugins/fs-db/src/version/macro.rsplugins/fs-db/src/migrations/v1_0_2_nightly_14_extract_from_sqlite.rsplugins/fs-db/src/migrations/v1_0_2_nightly_1_from_v0.rsplugins/listener/src/actors/recorder.rsgroup_by_session_idin two migration files (lifetime elision suffices)use tauri::Managerimport inapps/desktop/src-tauri/src/lib.rsplugins/cli2to workspace exclude list inCargo.toml(directory lacksCargo.toml, was causing workspace resolution failures)All changes are linting/style fixes with no intentional functional changes to logic. All meaningful CI checks pass (macOS, Linux x86_64, Linux aarch64, fmt).
Note: The
batchCI check fails due to a pre-existingcactus-sysARM build issue on x86 runners, unrelated to these changes.Review & Testing Checklist for Human
Risk level: Green (mechanical clippy fixes, all CI checks pass)
from_ast.rs,macro.rs) whilerecorder.rsuses standard formatting. dprint passed, but verify this variation is intentional.use tauri::Managerremoval doesn't affect macOS runtime behavior (CI tests passed, but runtime usage may differ from test coverage)Test plan
CI passing on all platforms (macOS, Linux x86_64, Linux aarch64) provides good coverage for these mechanical fixes. Consider spot-testing macOS desktop app startup to confirm Manager removal is safe.
Notes
if let X && let Y) requires Rust 1.64+; this repo uses 1.94 ✅