revert: undo keyboard-first navigation (#3963)#4059
Merged
ComputelessComputer merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This reverts commit 975620e.
abe9147 to
00ea8c1
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts all changes from PR #3963 ("support keyboard-first navigation"). This was done via
git revertwith one manual conflict resolution inpackages/store/src/zod.ts.Key reversions:
useSettingsNavigationhook and alldata-settings-item/data-settings-activatedata attributesctrl+alt+left/rightsub-tab keyboard navigation from AI and Settings viewsaiProviderSchemato usez.url().min(1)with the.refine()check requiring API keys for HTTPS URLs (conflict resolution — HEAD had simplified this toz.string())Review & Testing Checklist for Human
zod.tsconflict resolution: The revert restoresz.url().min(1)and the.refine()for HTTPS API key enforcement. PR support keyboard-first navigation #3963 comment landing v0 #7 noted this validation caused a UX bug ("if you clear the field, it shows an error message and when you open it again, it has 4 letters typed in"). Confirm this is acceptable or ifbase_urlshould stay asz.string()instead.data-settings-itemattributes or highlight styles are left in the app.Notes
Requested by: @ComputelessComputer
Link to Devin run