Skip to content

revert: undo keyboard-first navigation (#3963)#4059

Merged
ComputelessComputer merged 1 commit intomainfrom
devin/1771400208-revert-keyboard-first
Feb 18, 2026
Merged

revert: undo keyboard-first navigation (#3963)#4059
ComputelessComputer merged 1 commit intomainfrom
devin/1771400208-revert-keyboard-first

Conversation

@devin-ai-integration
Copy link
Contributor

Summary

Reverts all changes from PR #3963 ("support keyboard-first navigation"). This was done via git revert with one manual conflict resolution in packages/store/src/zod.ts.

Key reversions:

  • Removes useSettingsNavigation hook and all data-settings-item/data-settings-activate data attributes
  • Removes ctrl+alt+left/right sub-tab keyboard navigation from AI and Settings views
  • Removes keyboard highlight CSS
  • Restores aiProviderSchema to use z.url().min(1) with the .refine() check requiring API keys for HTTPS URLs (conflict resolution — HEAD had simplified this to z.string())

Review & Testing Checklist for Human

  • Verify zod.ts conflict resolution: The revert restores z.url().min(1) and the .refine() for HTTPS API key enforcement. PR support keyboard-first navigation #3963 comment landing v0 #7 noted this validation caused a UX bug ("if you clear the field, it shows an error message and when you open it again, it has 4 letters typed in"). Confirm this is acceptable or if base_url should stay as z.string() instead.
  • Test AI provider settings form: Open Settings → AI, try adding/editing a provider. Ensure the form behaves correctly with the restored URL validation.
  • Confirm no keyboard nav artifacts remain: Verify no data-settings-item attributes or highlight styles are left in the app.

Notes

Requested by: @ComputelessComputer
Link to Devin run

@netlify
Copy link

netlify bot commented Feb 18, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 00ea8c1
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69957d6ce080130008b7a6f7

@netlify
Copy link

netlify bot commented Feb 18, 2026

Deploy Preview for hyprnote-storybook canceled.

Name Link
🔨 Latest commit 00ea8c1
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/69957d6c25e9ed000805de37

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@ComputelessComputer ComputelessComputer force-pushed the devin/1771400208-revert-keyboard-first branch from abe9147 to 00ea8c1 Compare February 18, 2026 08:50
@ComputelessComputer ComputelessComputer merged commit f5f70fd into main Feb 18, 2026
14 of 15 checks passed
@ComputelessComputer ComputelessComputer deleted the devin/1771400208-revert-keyboard-first branch February 18, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant