Fix ModelWrapper method to preserve order of graph inputs and outputs #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltanar
approved these changes
Jun 6, 2025
|
Thanks for catching and fixing this @auphelia ! I took the liberty to add a unit test that triggers the problem which addressed by this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
set_tensor_shapeand the order of input and output tensors in the ONNX GraphProto. When setting the shape of these tensors, they used to be removed and then re-added, which potentially could mess up their order. This wasn't a problem for internal tensors (ValueInfo is unordered), but can lead to a reordering of graph.input or graph.output.In this PR, the code now fetches the current index of the tensor in graph.input or graph.output. It then inserts the updated tensor with its new shape back into the same spot, keeping the original order intact.