Correctly check if the package is up to date #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgsch
force-pushed
the
fgsch/fix-comparison
branch
2 times, most recently
from
66a9d5d
to
95f2df1
Compare
This was modified in 43ba5c2 by yours truly but turned to be the wrong approach. For consistent hashing, use hash-files.
Use the files hash instead of the (botched) hashsum approach; the latter never really worked due to discrepancies between the API and this tool.
fgsch
force-pushed
the
fgsch/fix-comparison
branch
from
95f2df1
to
0c8d331
Compare
|
After this PR, trying to deploy the same package shows: |
Integralist
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the files hash instead of the (botched) hashsum approach; the
latter never really worked due to discrepancies between the API and this
tool.