fastly backend create: override host cannot be an empty string #936

dcaba · 2023-05-16T12:54:42Z

Fixes #935

But there may be better ways of doing this (revisiting SetBackendHostDefaults() role or signature would be maybe a more elegant choice?)

…when we dont supply one but we supply a backend as an ip address

… effective override host to set

Integralist

LGTM. Thanks!

pkg/commands/backend/backend_test.go

dcaba added 2 commits May 16, 2023 14:27

test that demostrates we set a default empty string as override host …

0c43906

…when we dont supply one but we supply a backend as an ip address

dirty patch to ensure we are not setting empty strings if there is no…

59bdf81

… effective override host to set

dcaba marked this pull request as ready for review May 16, 2023 12:54

Integralist approved these changes May 16, 2023

View reviewed changes

pkg/commands/backend/backend_test.go Outdated Show resolved Hide resolved

pkg/commands/backend/backend_test.go Outdated Show resolved Hide resolved

Integralist added the bug Something isn't working label May 16, 2023

Integralist added 2 commits May 16, 2023 15:02

Update pkg/commands/backend/backend_test.go

f94d40d

Update pkg/commands/backend/backend_test.go

0fccdb0

Integralist merged commit 0e1a2b3 into fastly:main May 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fastly backend create: override host cannot be an empty string #936

fastly backend create: override host cannot be an empty string #936

dcaba commented May 16, 2023

Integralist left a comment

fastly backend create: override host cannot be an empty string #936

fastly backend create: override host cannot be an empty string #936

Conversation

dcaba commented May 16, 2023

Integralist left a comment

Choose a reason for hiding this comment