fix(compute/deploy): shorten message to avoid spinner bug #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: third-party package has a bug where long messages breaks the spinner.
Solution: workaround the bug by shortening the message.
Notes: I discovered this when creating a split terminal pane (bug report).
The workaround isn't perfect obviously because the terminal width depends on the user. So I've shortened this to a point where I think it probably works for most people. We've not had reports from users complaining about the spinner being broken so I don't think in practice this affects a lot of people, but worth shortening the message down regardless.