Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Elasticsearch logging endpoint support #90

Merged
merged 1 commit into from
May 27, 2020
Merged

Adds Elasticsearch logging endpoint support #90

merged 1 commit into from
May 27, 2020

Conversation

mccurdyc
Copy link
Collaborator

Relevant (Referenced) Link(s)

Validation

$ make test

git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
(
    cd /tmp/cli && \
    git checkout mccurdyc/logging-elasticsearch && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc mccurdyc requested a review from phamann May 26, 2020 18:07
@mccurdyc mccurdyc added the enhancement New feature or request label May 26, 2020
@mccurdyc mccurdyc marked this pull request as ready for review May 26, 2020 18:08
@mccurdyc
Copy link
Collaborator Author

Force-pushed addressing staticcheck and test checks.

(Maybe we consider pre-commit hooks?)

@mccurdyc mccurdyc mentioned this pull request May 26, 2020
Merged
phamann
phamann approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mccurdyc
logging: adds Elasticsearch logging endpoint support
8f1e798 
Signed-off-by: Colton J. McCurdy <cmccurdy@fastly.com>
@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master.

@mccurdyc mccurdyc merged commit cb8f4de into fastly:master May 27, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-elasticsearch branch May 27, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann