-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Azure Blob Storage logging endpoint support #89
Conversation
@phamann I assumed that we wanted to follow the naming convention (i.e., "blobstorage") in go-fastly. I would personally prefer something that identifies this as an "Azure Blob Storage" rather than just "blob storage" as I think "blob storage" has weighted meaning. But having consistency is also very important. |
Force-pushed addressing review comments (i.e., blobstorage -> azureblob) and squashing into a single commit.
|
Force-pushed gofmt check fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Force-pushed rebasing master. |
@@ -256,18 +257,25 @@ func Run(args []string, env config.Environment, file config.File, configFilePath | |||
digitaloceanUpdate := digitalocean.NewUpdateCommand(digitaloceanRoot.CmdClause, &globals) | |||
digitaloceanDelete := digitalocean.NewDeleteCommand(digitaloceanRoot.CmdClause, &globals) | |||
|
|||
statsRoot := stats.NewRootCommand(app, &globals) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize this was formatted this way when it got merged to master.
Relevant (Referenced) Link(s)
Validation