Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Azure Blob Storage logging endpoint support #89

Merged
merged 1 commit into from
May 27, 2020
Merged

Adds Azure Blob Storage logging endpoint support #89

merged 1 commit into from
May 27, 2020

Conversation

mccurdyc
Copy link
Collaborator

Relevant (Referenced) Link(s)

Validation

$ make test
git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
(
    cd /tmp/cli && \
    git checkout mccurdyc/logging-azure && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc mccurdyc requested a review from phamann May 26, 2020 14:57
@mccurdyc mccurdyc marked this pull request as ready for review May 26, 2020 14:57
@mccurdyc
Copy link
Collaborator Author

@phamann I assumed that we wanted to follow the naming convention (i.e., "blobstorage") in go-fastly.

I would personally prefer something that identifies this as an "Azure Blob Storage" rather than just "blob storage" as I think "blob storage" has weighted meaning. But having consistency is also very important.

@mccurdyc mccurdyc added the enhancement New feature or request label May 26, 2020
pkg/logging/blobstorage/root.go Outdated Show resolved Hide resolved
@mccurdyc
Copy link
Collaborator Author

mccurdyc commented May 26, 2020

Force-pushed addressing review comments (i.e., blobstorage -> azureblob) and squashing into a single commit.

  1. fd --exclude .git . -exec rename s/blobstorage/azureblob/ {} \;
  2. rename blobstorage azureblob pkg/logging/blobstorage*
  3. rename blobstorage azureblob pkg/logging/azureblob/*

@mccurdyc
Copy link
Collaborator Author

Force-pushed gofmt check fix.

@mccurdyc mccurdyc requested a review from phamann May 26, 2020 18:31
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master.

@@ -256,18 +257,25 @@ func Run(args []string, env config.Environment, file config.File, configFilePath
digitaloceanUpdate := digitalocean.NewUpdateCommand(digitaloceanRoot.CmdClause, &globals)
digitaloceanDelete := digitalocean.NewDeleteCommand(digitaloceanRoot.CmdClause, &globals)

statsRoot := stats.NewRootCommand(app, &globals)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this was formatted this way when it got merged to master.

@mccurdyc mccurdyc merged commit ae44b53 into fastly:master May 27, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-azure branch May 27, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants