Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to exclude files from build package #87

Merged
merged 6 commits into from
May 29, 2020

Conversation

phamann
Copy link
Member

@phamann phamann commented May 22, 2020

TL;DR

This adds two new features:

  • Change the default behaviour of compute build to not include the src directory in the package archive and add a --include-src flag if desired.
  • Add the ability to exclude files from the package archive via glob patterns defined in a .fastlyignore file in the root of the project.

Fixes #24.

Notes for reviewers:

I have renamed the existing compute integration style tests to a new file compute_integration_test.go which tests the external command API and have created a new compute_test.go to test the unexported (but still significant) functions within the package. Although I did a git mv the diff isn't pleasant, so it's easier to review the new commit directly. 4ce16bb

@phamann phamann requested a review from peterbourgon May 22, 2020 08:08
@phamann phamann force-pushed the phamann/package-files-ignore branch 3 times, most recently from dbf8065 to 4ce16bb Compare May 22, 2020 11:52
pkg/app/run_test.go Outdated Show resolved Hide resolved
pkg/compute/build.go Show resolved Hide resolved
pkg/compute/build.go Outdated Show resolved Hide resolved
@phamann phamann force-pushed the phamann/package-files-ignore branch from 2e614bb to fc06990 Compare May 22, 2020 14:15
pkg/compute/build.go Outdated Show resolved Hide resolved
pkg/compute/compute_intergration_test.go Outdated Show resolved Hide resolved
pkg/compute/build.go Show resolved Hide resolved
@phamann phamann force-pushed the phamann/package-files-ignore branch 2 times, most recently from e33569e to d6b2bca Compare May 27, 2020 13:38
@phamann phamann force-pushed the phamann/package-files-ignore branch from d6b2bca to b0308c8 Compare May 29, 2020 11:06
@phamann phamann force-pushed the phamann/package-files-ignore branch from b0308c8 to 76a3b16 Compare May 29, 2020 11:29
@phamann phamann merged commit 79101ac into master May 29, 2020
@phamann phamann added the enhancement New feature or request label May 29, 2020
@phamann phamann deleted the phamann/package-files-ignore branch October 22, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unintended files included in upload package
3 participants