Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds DigitalOcean Spaces logging endpoint support #80

Merged
merged 1 commit into from
May 21, 2020
Merged

Adds DigitalOcean Spaces logging endpoint support #80

merged 1 commit into from
May 21, 2020

Conversation

mccurdyc
Copy link
Collaborator

Relevant (Referenced) Link(s)

Validation

$ make test

git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
(
    cd /tmp/cli && \
    git checkout mccurdyc/logging-digitalocean && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc mccurdyc requested a review from phamann May 14, 2020 23:18
@mccurdyc mccurdyc added the enhancement New feature or request label May 14, 2020
@mccurdyc mccurdyc marked this pull request as ready for review May 14, 2020 23:25
@pteichman
Copy link
Contributor

Conflict fix is at df40a5f

@mccurdyc
Copy link
Collaborator Author

Force-pushed Peter's commit.

@mccurdyc
Copy link
Collaborator Author

Force-pushed new factory pattern and strengthened tests commits squashed into a single commit.

@mccurdyc
Copy link
Collaborator Author

Force-pushed a squashed commit addressing CI failure.

@mccurdyc
Copy link
Collaborator Author

Force-pushed squashed commit for staticcheck check fix.

(Should run these checks locally...)

phamann
phamann requested changes May 21, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the naming convention

pkg/logging/digitalocean/create.go Outdated Show resolved Hide resolved
@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master.

@mccurdyc
Copy link
Collaborator Author

Force-pushed addressing @phamann's review comment

find . -type f -exec sed -i 's/DigitalOcean logging/DigitalOcean Spaces logging/g' {} \;

@mccurdyc mccurdyc requested a review from phamann May 21, 2020 13:52
phamann
phamann reviewed May 21, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more 😉

pkg/logging/digitalocean/list.go Outdated Show resolved Hide resolved
@mccurdyc
logging: adds DigitalOcean Spaces logging endpoint support
8d91a28 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
@mccurdyc
Copy link
Collaborator Author

Force-pushed addressing @phamann's review comment.

(Well, at least you can see why my previous "fix" wasn't a fix) :)

Sorry for not catching that.

@mccurdyc mccurdyc requested a review from phamann May 21, 2020 14:37
phamann
phamann approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mccurdyc mccurdyc merged commit 035015d into fastly:master May 21, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-digitalocean branch May 21, 2020 15:13
@mccurdyc mccurdyc changed the title logging: adds DigitalOcean Spaces logging endpoint support Adds DigitalOcean Spaces logging endpoint support May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mccurdyc @pteichman @phamann