Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compute/deploy): add Secret Store to manifest [setup] #769

Merged
merged 3 commits into from
Apr 13, 2023
Merged

feat(compute/deploy): add Secret Store to manifest [setup] #769

merged 3 commits into from
Apr 13, 2023

Conversation

awilliams-fastly
Copy link
Collaborator

@awilliams-fastly awilliams-fastly commented Jan 20, 2023 •
edited
Loading

Adds ability to define Secret Stores in the [setup] section of a fastly.toml config file. The user will be prompted to create the defined stores and secrets on creation of a service when using fastly compute deploy.

Related: #717, #764

Base automatically changed from awilliams/secret-store to main January 24, 2023 16:37
@Integralist Integralist added the enhancement New feature or request label Feb 6, 2023
@awilliams-fastly awilliams-fastly mentioned this pull request Apr 12, 2023
Merged
@awilliams-fastly awilliams-fastly marked this pull request as ready for review April 12, 2023 16:42
awilliams-fastly
awilliams-fastly commented Apr 12, 2023
View reviewed changes
pkg/commands/compute/deploy.go Outdated
kvStores *setup.KVStores
secretStores *setup.SecretStores
}

func constructSetupKVs(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note: https://github.com/fastly/cli/pull/904/files#r1164377390

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this should be constructSetupObjects

@awilliams-fastly
feat(compute/deploy): add Secret Store to manifest [setup]
827d439 
Adds ability to define Secret Stores in the `[setup]` section of a `fastly.toml` config file.
The user will be prompted to create the defined stores and secrets on creation of a service when using `fastly compute deploy`.

Related: #717, #764
Integralist
Integralist approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested edit otherwise LGTM. Thanks for refactoring the multiple returned objects into a single object, much cleaner and future proof 👍🏻

pkg/commands/compute/setup/secret_store.go Outdated Show resolved Hide resolved
@Integralist
Copy link
Collaborator

Oh I forgot about constructSetupObjects, yes please if you could update that. Thanks!

@awilliams-fastly awilliams-fastly merged commit e977ad3 into main Apr 13, 2023
@awilliams-fastly awilliams-fastly deleted the awilliams/secret-store-setup branch April 13, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

@joeshaw joeshaw Awaiting requested review from joeshaw

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awilliams-fastly @Integralist