Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Heroku logging endpoint support #76

Merged
merged 1 commit into from
May 20, 2020
Merged

Adds Heroku logging endpoint support #76

merged 1 commit into from
May 20, 2020

Conversation

mccurdyc
Copy link
Collaborator

Relevant (Referenced) Link(s)

Validation

$ make test

git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
(
    cd /tmp/cli && \
    git checkout mccurdyc/logging-heroku && \
    make test && \
    rm -rf /tmp/cli \
)

@mccurdyc mccurdyc requested a review from phamann May 14, 2020 18:48
@mccurdyc mccurdyc marked this pull request as ready for review May 14, 2020 18:52
@mccurdyc mccurdyc added the enhancement New feature or request label May 14, 2020
@pteichman
Copy link
Contributor

Conflict fix is 2837972

I squashed the first two commits together since they were both necessary to get a clean build.

@mccurdyc
Copy link
Collaborator Author

Force-pushed Peter's commit.

@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master.

@mccurdyc
Copy link
Collaborator Author

Force-pushed squashing into single commit.

@mccurdyc
Copy link
Collaborator Author

Force-pushed squashed commit including stronger tests.

phamann
phamann approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mccurdyc
logging: adds Heroku logging endpoint support
ada3c81 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master.

@mccurdyc mccurdyc merged commit 87ec083 into fastly:master May 20, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-heroku branch May 20, 2020 18:34
@mccurdyc mccurdyc changed the title logging: adds Heroku logging endpoint support Adds Heroku logging endpoint support May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mccurdyc @pteichman @phamann