Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing first byte timeout in backend update command #667

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

cs278
Copy link
Contributor

@cs278 cs278 commented Oct 11, 2022

Using the --first-byte-timeout option would always update the timeout to zero regardless of the value supplied.

Example:

$ fastly backend update --name test --version latest --first-byte-timeout=10000
...
$ fastly backend describe --name test --version latest

Service ID: ...
Service Version: 16

Name: ...
Comment: 
Address: ...
Port: 443
Override host: 
Connect timeout: 10000
Max connections: 200
First byte timeout: 0
Between bytes timeout: 5000
...

Using the `--first-byte-timeout` option would always update the
timeout to zero regardless of the value supplied.
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice! Good spot. Thank you for the PR ❤️

@Integralist Integralist merged commit bd156d3 into fastly:main Oct 11, 2022
@cs278 cs278 deleted the fix-backend-update-fbt-option branch October 11, 2022 14:14
@Integralist Integralist added the bug Something isn't working label Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants