Reduce duplication of strings in logging package #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
reviewed
Oct 4, 2022
There was a problem hiding this comment.
Thanks @grantstephens for opening this PR.
I have a couple of comments for you.
grantstephens
force-pushed
the
grantstephens/LOG-1354
branch
2 times, most recently
from
d0d376f
to
8f843e2
Compare
grantstephens
force-pushed
the
grantstephens/LOG-1354
branch
from
8f843e2
to
ace917b
Compare
Integralist
reviewed
Oct 6, 2022
Integralist
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://fastly.atlassian.net/browse/LOG-1354