Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compute hashsum #649

Merged
merged 5 commits into from
Sep 29, 2022
Merged

Implement compute hashsum #649

merged 5 commits into from
Sep 29, 2022

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Sep 28, 2022

NOTE: It has been agreed that we should remove the pkg/app/run_test.go TestApplication as it's not a useful test and is more noise than signal

@Integralist Integralist added the enhancement New feature or request label Sep 28, 2022
@fgsch
Copy link
Member

fgsch commented Sep 28, 2022

Looks good to me.

I'd expect to see the build output when using -v, however. What do you think?

@Integralist
Copy link
Collaborator Author

Added support for showing build output with --verbose flag...

Screenshot 2022-09-29 at 11 59 29

Copy link
Member

@fgsch fgsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fgsch
Copy link
Member

fgsch commented Sep 29, 2022

🚢 🇮🇹

@Integralist Integralist merged commit 11902b4 into main Sep 29, 2022
@Integralist Integralist deleted the integralist/hashsum branch September 29, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants