Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Splunk endpoint #64

Merged
merged 1 commit into from
May 19, 2020
Merged

Adds Splunk endpoint #64

merged 1 commit into from
May 19, 2020

Conversation

mccurdyc
Copy link
Collaborator

@mccurdyc mccurdyc commented May 8, 2020 •
edited
Loading

Relevant (Referenced) Link(s)

Validation

$ make test

git clone git@github.com:mccurdyc/cli.git /tmp/cli && \
( 
    cd /tmp/cli && \
    git checkout mccurdyc/logging-splunk && \
    make test && \
    rm -rf /tmp/cli \
)

TODOs

  • I didn't realize until later that we should update fastly/go-fastly to pull
    in the recent changes to add the TLS-related fields for Splunk configuration.

@phamann phamann added the enhancement New feature or request label May 11, 2020
phamann
phamann requested changes May 14, 2020
View reviewed changes
pkg/logging/splunk/create.go Outdated Show resolved Hide resolved
@mccurdyc mccurdyc marked this pull request as ready for review May 14, 2020 20:10
@mccurdyc mccurdyc requested a review from phamann May 14, 2020 20:10
@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master to obtain go-fastly v1.11.0 changes to include TLS fields.

@mccurdyc mccurdyc changed the title logging: adds splunk endpoint logging: adds Splunk endpoint May 14, 2020
phamann
phamann approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pteichman
Copy link
Contributor

Conflict fix is over at 1d1a062

@mccurdyc
Copy link
Collaborator Author

Force-pushed Peter's extremely kind commit :)

@mccurdyc
Copy link
Collaborator Author

Force-pushed rebasing master after merging #63

@mccurdyc
logging: adds splunk endpoint support
af9ef16 
Signed-off-by: Colton McCurdy <cmccurdy@fastly.com>
@mccurdyc
Copy link
Collaborator Author

Force-pushed squashing into a single commit.

@mccurdyc mccurdyc merged commit c9c25eb into fastly:master May 19, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-splunk branch May 19, 2020 17:54
@mccurdyc mccurdyc changed the title logging: adds Splunk endpoint Adds Splunk endpoint May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mccurdyc @pteichman @phamann