Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows ANSI escape code rendering #503

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Jan 6, 2022

Use color.Output instead of os.Stdout as it will determine the correct Windows output stream.

Also use color.Error in place of os.Stderr.

Screenshot

The following screenshot demonstrates both printing using color.Output which renders as bold, and colour.Error for when an error occurs.

Screenshot 2022-01-06 at 11 14 17

@Integralist Integralist added the bug Something isn't working label Jan 6, 2022
@Integralist Integralist requested review from a team and doramatadora and removed request for a team January 6, 2022 10:50
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Integralist Integralist merged commit 425aa4d into main Jan 6, 2022
@Integralist Integralist deleted the integralist/windows-ansi branch January 6, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants