Implement --service-name as swap-in replacement for --service-id
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
a team and
kailan
and removed request for
a team
Integralist
commented
Dec 20, 2021
Comment on lines
+34
to
+40
| // RegisterServiceNameFlag defines a --service-name flag that will attempt to | ||
| // acquire the Service ID associated with the given service name. | ||
| // | ||
| // See: cmd.OptionalServiceNameID.Parse() | ||
| func (b Base) RegisterServiceNameFlag(action kingpin.Action, dst *string) { | ||
| b.CmdClause.Flag("service-name", "The name of the service").Action(action).StringVar(dst) | ||
| } |
There was a problem hiding this comment.
Here's the new abstraction for creating a --service-name flag.
Comment on lines
+106
to
+125
| // OptionalServiceNameID represents a mapping between a Fastly service name and | ||
| // its ID. | ||
| type OptionalServiceNameID struct { | ||
| OptionalString | ||
| } | ||
|
|
||
| // Parse returns a service ID based off the given service name. | ||
| func (sv *OptionalServiceNameID) Parse(client api.Interface) (serviceID string, err error) { | ||
| services, err := client.ListServices(&fastly.ListServicesInput{}) | ||
| if err != nil { | ||
| return serviceID, fmt.Errorf("error listing services: %w", err) | ||
| } | ||
| for _, s := range services { | ||
| if s.Name == sv.Value { | ||
| return s.ID, nil | ||
| } | ||
| } | ||
| return serviceID, errors.New("error matching service name with available services") | ||
| } | ||
|
|
There was a problem hiding this comment.
Here is where we implement the logic for mapping a service name to an ID.
| @@ -39,6 +40,7 @@ func NewCreateCommand(parent cmd.Registerer, globals *config.Data, data manifest | |||
| c.manifest = data | |||
| c.CmdClause = parent.Command("create", "Create a backend on a Fastly service version").Alias("add") | |||
| c.RegisterServiceIDFlag(&c.manifest.Flag.ServiceID) | |||
| c.RegisterServiceNameFlag(c.serviceName.Set, &c.serviceName.Value) | |||
There was a problem hiding this comment.
Here is an example of using the new --service-name abstraction.
kailan
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #481