Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid triggering GitHub API rate limit when running Viceroy in CI #488

Merged
merged 5 commits into from
Jan 4, 2022
Merged

Avoid triggering GitHub API rate limit when running Viceroy in CI #488

merged 5 commits into from
Jan 4, 2022

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Dec 15, 2021 •
edited
Loading

Problem: When running in CI...

fastly compute serve --addr "127.0.0.1":7879 --skip-build
Initializing...
Checking latest Viceroy release...

ERROR: error fetching latest version: 
GET https://api.github.com/repos/fastly/viceroy/releases/latest: 
403 API rate limit exceeded for xx.xxx.xxx.xxx. 

(But here's the good news: Authenticated requests get a higher rate limit. 
Check out the documentation for more details.) [rate reset in 32m07s].

NOTE: This PR is blocked by #489

@Integralist Integralist added the bug Something isn't working label Dec 15, 2021
@Integralist Integralist mentioned this pull request Dec 15, 2021
Merged
@Integralist Integralist force-pushed the integralist/viceroy-triggers-gh-ratelimit branch from 3c349db to 6bfd15a Compare December 16, 2021 10:02
@Integralist Integralist force-pushed the integralist/viceroy-triggers-gh-ratelimit branch from 7cf6299 to d818a39 Compare December 16, 2021 13:31
@Integralist Integralist force-pushed the integralist/viceroy-triggers-gh-ratelimit branch from d818a39 to 075f126 Compare January 4, 2022 12:48
@Integralist Integralist merged commit 9062f2f into main Jan 4, 2022
@Integralist Integralist deleted the integralist/viceroy-triggers-gh-ratelimit branch January 4, 2022 13:06
@byteshiva byteshiva mentioned this pull request Jan 26, 2022
Closed
@GeeWee GeeWee mentioned this pull request Dec 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailan kailan kailan approved these changes

@fgsch fgsch Awaiting requested review from fgsch

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @kailan