Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display viceroy --version if installed #487

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Display viceroy --version if installed #487

merged 1 commit into from
Dec 16, 2021

Conversation

Integralist
Copy link
Collaborator

To aid debugging we will now display the viceroy --version output when a user executes the fastly version command...

$ fastly version
Fastly CLI version v0.0.0-unknown (unknown)                                                                                                                                                                                                   
Built with go version unknown                                                                                                                                                                                                                 
Viceroy version: viceroy 0.0.0

fgsch
fgsch approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@fgsch fgsch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but code wise looks good to me.
I trust your judgement. 👍

@fgsch fgsch added the enhancement New feature or request label Dec 16, 2021
@Integralist Integralist merged commit 8c2a969 into main Dec 16, 2021
@Integralist Integralist deleted the integralist/add-viceroy-version branch December 16, 2021 13:31
@fgsch
Copy link
Member

fgsch commented Dec 16, 2021

I've now tested it and works as advertised. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgsch fgsch fgsch approved these changes

@kailan kailan Awaiting requested review from kailan

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @fgsch