Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to avoid this situation where we have to set the flags to the same value:
Instead it would better if the user could just set:
NOTE: I went back and updated the
compute deploy
logic so it includedssl-cert-hostname
as we were only handlingoverride-host
andssl-sni-hostname
.Examples
1. Allow empty values
If user sets the flags (
--override-host
,--ssl-cert-hostname
,--ssl-sni-hostname
) with an empty string, then let those values be used.2. Allow individual values
If user sets the flags (
--override-host
,--ssl-cert-hostname
,--ssl-sni-hostname
) with unique values, then let those values be used.3. Ensure sensible defaults
If user omits all three flags (
--override-host
,--ssl-cert-hostname
,--ssl-sni-hostname
) and if--address
is a hostname, then set all three field values to the hostname given in the--address
flag.4. Validate IP address behaviour
If user omits all three flags (
--override-host
,--ssl-cert-hostname
,--ssl-sni-hostname
) and if--address
is an IP, then don't set a value for any of the field values.