Better error handling for manifest parsing #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailan
approved these changes
Oct 13, 2021
Integralist
force-pushed
the
integralist/error-handling-manifest
branch
from
fbfb705
to
fa0f092
Compare
Integralist
force-pushed
the
integralist/error-handling-manifest
branch
from
fa0f092
to
2d56da2
Compare
Integralist
force-pushed
the
integralist/error-handling-manifest
branch
from
da0f469
to
d372a73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some odd behaviour when doing a last round of manual testing before cutting a new release. This PR addresses some of the problems with the original logic.