Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CLI config using flag on update command #382

Merged
merged 2 commits into from
Sep 2, 2021
Merged

update CLI config using flag on update command #382

merged 2 commits into from
Sep 2, 2021

Conversation

Integralist
Copy link
Collaborator

Fixes #377

@Integralist Integralist added the enhancement New feature or request label Sep 2, 2021
kailan
kailan approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@kailan kailan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very helpful addition, thanks!

phamann
phamann reviewed Sep 2, 2021
View reviewed changes
pkg/app/run_test.go Outdated Show resolved Hide resolved
@Integralist Integralist merged commit 6fb8344 into main Sep 2, 2021
@Integralist Integralist deleted the integralist/update-config-flag branch September 2, 2021 14:02
@softprops
Copy link

when do we think we can see this in a release?

@Integralist
Copy link
Collaborator Author

Hi @softprops I'm hoping to cut a new release in the next day or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann left review comments

@kailan kailan kailan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide an update-config subcommand or cut a new release
4 participants
@Integralist @softprops @phamann @kailan