Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logging newrelic command #354

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Implement logging newrelic command #354

merged 2 commits into from
Jul 30, 2021

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Jul 27, 2021 •
edited
Loading

No description provided.

@Integralist Integralist added the enhancement New feature or request label Jul 27, 2021
@Integralist Integralist requested review from a team and triblondon and removed request for a team July 27, 2021 11:55
@Integralist Integralist marked this pull request as ready for review July 27, 2021 13:38
@Integralist
Copy link
Collaborator Author

@triblondon based on my updated understanding of go-fastly's use of mapstructure to convert strings to integers this PR should be safe to review and won't require any changes to go-fastly.

@Integralist Integralist force-pushed the integralist/newrelic branch 2 times, most recently from cb134f3 to ecd602a Compare July 29, 2021 11:11
@Integralist Integralist requested a review from kailan July 29, 2021 12:34
@Integralist
Copy link
Collaborator Author

👋🏻 @kailan just adding you to the review team for this PR.

kailan
kailan approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@kailan kailan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me + working on my machine 🚀

@Integralist Integralist merged commit 68d66c0 into main Jul 30, 2021
@Integralist Integralist deleted the integralist/newrelic branch July 30, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailan kailan kailan approved these changes

@triblondon triblondon Awaiting requested review from triblondon

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @kailan