Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom vcl endpoints #310

Merged
merged 16 commits into from
Jun 17, 2021
Merged

add custom vcl endpoints #310

merged 16 commits into from
Jun 17, 2021

Conversation

@Integralist Integralist force-pushed the integralist/phase1-vcl-custom branch 3 times, most recently from a4c50dd to 2f8a55e Compare June 15, 2021 09:54
@phamann
Copy link
Member

phamann commented Jun 15, 2021

Whats the reasoning for nesting this under a fastly vcl custom namespace and not fastly vcl create etc? I ask as this breaks convention and the UX defined elsewhere in the project.

@Integralist Integralist force-pushed the integralist/phase1-vcl-custom branch 2 times, most recently from 7186f3a to 238e184 Compare June 15, 2021 11:30
@Integralist
Copy link
Collaborator Author

Whats the reasoning for nesting this under a fastly vcl custom namespace

@phamann because in the near future we will also have...

  • fastly vcl cache-settings create
  • fastly vcl cache-settings delete
  • fastly vcl cache-settings describe
  • fastly vcl cache-settings list
  • fastly vcl cache-settings update
  • fastly vcl condition create
  • fastly vcl condition delete
  • fastly vcl condition describe
  • fastly vcl condition list
  • fastly vcl condition update
  • fastly vcl custom create [--main]
  • fastly vcl custom delete
  • fastly vcl custom describe
  • fastly vcl custom list
  • fastly vcl custom update [--main]
  • fastly vcl diff
  • fastly vcl gzip create
  • fastly vcl gzip delete
  • fastly vcl gzip describe
  • fastly vcl gzip list
  • fastly vcl gzip update
  • fastly vcl header-object create
  • fastly vcl header-object delete
  • fastly vcl header-object describe
  • fastly vcl header-object list
  • fastly vcl header-object update
  • fastly vcl request-settings create
  • fastly vcl request-settings delete
  • fastly vcl request-settings describe
  • fastly vcl request-settings list
  • fastly vcl request-settings update
  • fastly vcl response-object create
  • fastly vcl response-object delete
  • fastly vcl response-object describe
  • fastly vcl response-object list
  • fastly vcl response-object update
  • fastly vcl settings describe
  • fastly vcl settings update
  • fastly vcl snippet create
  • fastly vcl snippet delete
  • fastly vcl snippet describe
  • fastly vcl snippet list
  • fastly vcl snippet update

@Integralist Integralist marked this pull request as ready for review June 16, 2021 14:37
@Integralist Integralist requested review from a team and triblondon and removed request for a team June 16, 2021 14:37
@Integralist Integralist marked this pull request as draft June 16, 2021 14:38
@Integralist Integralist requested review from a team and kailan and removed request for triblondon and a team June 16, 2021 14:38
@Integralist Integralist marked this pull request as ready for review June 16, 2021 16:37
@Integralist Integralist added the enhancement New feature or request label Jun 16, 2021
Copy link
Member

@kailan kailan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed over Zoom with @Integralist – this PR is great and lays some important groundwork for the upcoming command phases!

🚀

@Integralist Integralist force-pushed the integralist/phase1-vcl-custom branch from 09bc17a to 26948cc Compare June 17, 2021 12:30
@Integralist Integralist merged commit 30e1140 into main Jun 17, 2021
@Integralist Integralist deleted the integralist/phase1-vcl-custom branch June 17, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants