Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't persist --service-id flag value to manifest #307

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

Integralist
Copy link
Collaborator

Fixes #305

@Integralist Integralist requested review from a team and kailan and removed request for a team June 14, 2021 12:32
@Integralist Integralist added the bug Something isn't working label Jun 14, 2021
@Integralist Integralist requested review from abanez, triblondon and doramatadora and removed request for abanez June 14, 2021 13:16
Copy link
Contributor

@doramatadora doramatadora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@Integralist Integralist merged commit c8dbff7 into main Jun 14, 2021
@Integralist Integralist deleted the integralist/dont-persist-sid-flag-value branch June 14, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fastly compute publish --service-id replaces the service_id value in fastly.toml
2 participants