Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up fastly configure text output #30

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Conversation

phamann
Copy link
Member

@phamann phamann commented Apr 22, 2020

TL;DR

Fixes #27 to prevent the value of a API token supplied by an environment variable being rendered in the output and clean-up the output to be more consistent with other commands:

  • Use progress writer to update progression through validation and persistence steps.
  • Use text.Description to output the config file location
  • Move config file location before success message as this was confusing some users.

Example:

Screenshot 2020-04-22 at 16 32 16

@phamann phamann added the bug Something isn't working label Apr 22, 2020
Copy link
Contributor

@pteichman pteichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like having separate output depending on where the token came from.

👍

@phamann phamann merged commit 6de55d0 into master Apr 22, 2020
@phamann phamann deleted the phamann/fix-configure-token branch April 22, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't display the fastly token in the terminal when doing fastly configure
2 participants