Improve toolchain installation help messaging #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y and the command to run more explicit.
peterbourgon
approved these changes
Feb 20, 2020
|
Will that command work reliably on all target systems? |
phamann
added a commit
that referenced
this pull request
Mar 11, 2020
* Don't print RemediationError's via text.Output to ensure whitespace is kept intact. * Make rust toolchain installation remediation errors more user friendly and the command to run more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improves the UX of the remediation error messages for Rust toolchain installation.
Why?
We've noticed in various user testing sessions that the current text wasn't explicit enough and didn't differentiate the command output from the other help text. It also seems a previous refactor to how remediation messages are printed (via
text.Output()) was causing the whitespace in the (\n\tetc) to be stripped.Previous output:
New output: