Move undo behaviour from common to own package #293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: I'm increasingly stumbling into issues with the
common
package being too broad/generic. This materialises as an "import cycle error". It is also considered bad practice to have folders namedcommon
orutils
etc.Solution: Move these behaviours into their own packages.
Example: I would like to add a remediation error type to some code in our
config
package. This isn't possible because importing theerrors
package will importtext
which will importcommon
and the common package has already been imported earlier in the import cycle: