Fix panic when dealing with empty manifest. #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when updating the manifest we were creating a new instance type of the manifest file, one that didn't have the internal
outputfield set. This would ultimately cause a runtime panic.Solution: we already have an instance of the manifest type, with the output set, so pass that into the relevant function to use.
Notes: the reason this panic materialised when dealing with an empty manifest is because the manifest needed to be updated to include a
manifest_versionfield and so it's at that point that we need to use theoutputfield for displaying information to the user.