Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --force flag not being respected. #272

Merged
merged 1 commit into from
May 11, 2021
Merged

Fix --force flag not being respected. #272

merged 1 commit into from
May 11, 2021

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented May 10, 2021 •
edited
Loading

Problem: an error message about the directory not being empty would be displayed regardless of whether you passed --force.

@Integralist Integralist added the bug Something isn't working label May 10, 2021
@Integralist Integralist marked this pull request as ready for review May 11, 2021 12:39
@Integralist Integralist requested a review from kailan May 11, 2021 12:40
kailan
kailan approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@kailan kailan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Integralist Integralist merged commit 5c64a44 into main May 11, 2021
@Integralist Integralist deleted the integralist/fix-force-flag branch May 11, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailan kailan kailan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @kailan