Remove version from fastly.toml manifest. #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
a team and
triblondon
and removed request for
a team
Integralist
commented
Mar 17, 2021
| wantOutput: []string{ | ||
| "Validating package...", | ||
| "Uploading package...", | ||
| "Activating version...", | ||
| "Updating package manifest...", |
There was a problem hiding this comment.
@triblondon this integration test suggests to me that the 'version' field in Northstar isn't preventing a package from being built and deployed. Which is a good thing.
There was a problem hiding this comment.
because it still passes after this change?
triblondon
approved these changes
Mar 17, 2021
|
I can confirm that running this local build of the CLI that I was able to initialise, build and deploy a service to C@E with no issues. So this should be fine to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: storing state into fastly.toml is the signs that we're beginning to tread on the toes of a tool like terraform. Additionally, although we set the current service version within the manifest we don't actually use it for anything in the CLI so it looks to be a redundant field regardless.