Refactor UserAgent. #219
Merged
Refactor UserAgent. #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
requested review from
phamann,
a team,
triblondon and
kailan
and removed request for
a team
kailan
reviewed
Mar 17, 2021
kailan
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: we weren't setting the User-Agent HTTP request header when making requests to the dynamic config endpoint.
Notes: in order to support this change I needed to make a bunch of refactoring. Otherwise without the refactoring we would have had to duplicate the UserAgent logic due to 'cyclic import' issues.
Also, we already had a package named
versionwhich is used for a subsequent CLI subcommand. So I had to find an alternative name to encapsulate a bunch of version related types. So I settled on 'revision'. It might not be the best name so I'm open to suggestions.