Override error message in compute init #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
approved these changes
Feb 15, 2021
| @@ -355,6 +355,12 @@ func (c *InitCommand) Exec(in io.Reader, out io.Writer) (err error) { | |||
| Comment: description, | |||
| }) | |||
| if err != nil { | |||
| if strings.Contains(err.Error(), "Valid values for 'type' are: 'vcl'") { | |||
There was a problem hiding this comment.
Using strings.Contains for checking an error always make me a little nervous due to its brittle nature. Sadly I'm not sure if there's a way around this. I just wanted to vocalise that this might be a problem that resurfaces if the backend API ever changes the text content.
There was a problem hiding this comment.
Yep, this is not great – we would want an error code to match on in an ideal world. For now this will have to do though, unless anyone has any suggestions.
kailan
force-pushed
the
kailan/ecp-feature-error
branch
from
57d03e8
to
e76eb45
Compare
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
kailan
force-pushed
the
kailan/ecp-feature-error
branch
from
e76eb45
to
eb63cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @ezambrano-fastly, users without the C@E feature flag enabled currently see a relatively cryptic message: "Unable to create service: valid values for 'type' are: 'vcl'"